Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump core-js for es5 package #2195

Merged
merged 5 commits into from
Jul 16, 2019
Merged

Bump core-js for es5 package #2195

merged 5 commits into from
Jul 16, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Jul 16, 2019 •
edited
Loading

Fixes #2187

Changelog

Description

Changes made by adding eslint rules caused core-js modules to fail on the es5 build of Web Chat. This fix bumps core-js in bundle and modifies the imported modules to the index-es5 module.

Specific Changes

  • bump core-js
  • update core-js modules in index-es5.ts

This will be patched to 4.5

  • Testing Added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.308% when pulling bc10372 on corinagum:fix-2187 into 6e5ca98 on microsoft:master.

@corinagum corinagum merged commit 80ce118 into microsoft:master Jul 16, 2019
@corinagum corinagum mentioned this pull request Jul 31, 2019
Closed
@compulim compulim mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive card render error in IE11
3 participants
@corinagum @coveralls @compulim